BS
← All projectsBlockstream

Blockstream Jade

Firmware for Jade and Jade Plus Bitcoin hardware wallets.

BitcoinHardware walletsElevated watch
Repository coverage

414 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

93security candidates58second-pass queue155AI analyses
10commits · 30 days
67commits · 60 days
198commits · 180 days
414commits · 365 days
Backfill bands
Aug 5 → Feb 6216 seen38 candidatesComplete
Feb 6 → Jun 6131 seen9 candidatesComplete
Jun 6 → Jul 657 seen10 candidatesComplete
Jul 6 → Aug 510 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
32Strong · 80–100
147Adequate · 60–79
203Thin · 40–59
32Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths2755292157
Mike Tolkachev311117155
Daniel Newton651525055
Mihailo Milenkovic878057
Jamie C. Driver525053
Gustavo Cateim712079
Austin-Fulbright411060
cmiguelrn111045
quantpoet111072
roderico111045
tokyovyse111063
Valerio Vaccaro200045
Analysis record

Published AI watches

Last scanned 32 minutes ago

Informational 15 AI analysisMessage 68 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

hardware: add Jade Plus design files

This commit reorganizes existing hardware design files for the original Jade device into a new subfolder and adds the open-source hardware design files for a new product, the Jade Plus. It does not change any software, firmware, or device …

5ad85661by bitcoinhelp+2573−122520 files
No security note in commit
Low 26 AI analysisMessage 100 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

power: release PMU devices before deleting the i2c bus on M5CoreS3

This commit fixes a boot failure on the M5CoreS3 hardware. A recent update to the underlying Espressif SDK (ESP-IDF v5.5) changed the rules for deleting an I2C bus: it now refuses to delete a bus that still has devices attached. The power …

fb3a009aby Gustavo Cateim+3−01 file
No security note in commit
Low 27 AI analysisMessage 86 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

input: release touch handles before deleting the i2c bus

This commit fixes a bug where the touchscreen driver failed to clean up internal handles when shutting down. On newer ESP-IDF firmware, this cleanup failure caused the device to panic and freeze during boot and when using the camera or QR …

Device freeze/DoS-like symptom on affected hardwareMemory leak fixedNo input validation, authentication, or cryptographic weakness visible
36776fecby Gustavo Cateim+3−01 file
No security note in commit
Informational 15 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

jade_cli: add selfcheck command

This commit adds a new command-line command called 'selfcheck' to the Jade CLI tool. It simply calls an existing device function and prints the result. There is no indication of a security fix or vulnerability being patched.

32d3c9a7by Jon Griffiths+10−01 file
No security note in commit
Low 42 AI analysisMessage 95 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

Liquid (taproot): add sign_liquid_tx genesis blockhash support

This commit changes how Blockstream Jade handles the 'genesis blockhash' when signing Liquid transactions. Previously, the device only accepted the network's built-in genesis hash. Now it lets users provide a custom genesis hash for test n…

Adds input validation for caller-supplied genesis blockhashPrevents mainnet genesis hash from being used on Liquid test networksRestricts genesis_hash parameter to Liquid networks only
888eff30by Jon Griffiths+82−264 files
No security note in commit
Low 48 AI analysisMessage 62 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: annotate functions returning error codes to ensure they are checked

This commit adds compiler annotations (WARN_UNUSED_RESULT) to functions that return success/failure codes, so the compiler will warn if a caller ignores the result. It also fixes a few places where return values were being ignored, replaci…

Functions returning error/success codes annotated with WARN_UNUSED_RESULTCallers now check return values of rpc_get_bip32_path() and rpc_get_boolean()Use of default-value helpers (rpc_get_boolean_or) to ensure predictable behavior on missing fields
517075baby Mike Tolkachev+24−215 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: rename get_uint64_t to get_uint64

This commit simply renames an internal helper function from `rpc_get_uint64_t` to `rpc_get_uint64` and updates every place that calls it. There are no changes to what the function does, how it checks data, or how secure it is. It is a rout…

8e0de45eby Jon Griffiths+11−117 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: rename get_boolean to get_bool

This commit is a simple rename of two internal helper functions from `rpc_get_boolean`/`rpc_get_boolean_or` to `rpc_get_bool`/`rpc_get_bool_or`, updating all call sites accordingly. There is no change to what the code does, no bug fix, and…

f6e946acby Jon Griffiths+24−2518 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: refactor app code to use getters with default values

This commit is a straightforward code cleanup that replaces verbose 'read this optional value, or leave the default' patterns with shorter helper functions that do the same thing. There is no change in behavior and no security issue visibl…

b6a07147by Mike Tolkachev+22−348 files
No security note in commit
Moderate 59 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: improve precision checking

This commit tightens how Blockstream Jade handles the 'precision' value in asset contracts for Liquid assets. Previously, a very large precision value could be accepted and later used to read past the end of an internal lookup table (POW_1…

Out-of-bounds read mitigation: bounds-checking of user-controlled precision before indexing fixed-size POW_10 arrayInteger truncation safety: explicit cast of validated precision to uint8_t after range checkCompile-time invariant enforcement: JADE_STATIC_ASSERT ties array size to ASSET_PRECISION_MAX
fd0f625dby Mike Tolkachev+13−13 files
No security note in commit
Informational 15 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

docker: update jade_builder

This commit simply updates the SHA256 digest of the 'blockstream/jade_builder' Docker image used for building and testing Jade in four configuration files. There is no code change, no disclosed security fix, and no evidence in the commit o…

00e7a397by Jon Griffiths+5−54 files
No security note in commit
Low 40 AI analysisMessage 78 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

libjade: add camera/input/nvs support, refactor

This commit is a large feature/refactor patch for Blockstream Jade's libjade (a desktop emulator of the Jade hardware wallet). It adds RPC endpoints that let a host application read the emulated device's screen, push fake button presses, r…

New RPC endpoints allow external read/write of emulated NVS storageNew RPC endpoints allow external screen capture and synthetic input injectionNew RPC endpoints allow external camera frame injection
f7184945by Daniel Newton+1806−75832 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

Fix M5StickC Plus 2 PIN navigation

This commit fixes a user-interface navigation quirk on the M5StickC Plus 2 hardware for Blockstream Jade. When entering a PIN, the up/down button directions were not inverted to match the rest of the device's menus, making number entry con…

9de1409eby roderico+3−21 file
No security note in commit
Low 36 AI analysisMessage 74 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

build: annotate functions returning error codes to ensure they are checked

This commit is a preventive build-hardening change. It adds compiler annotations (WARN_UNUSED_RESULT) to many functions that return success/failure codes, so the compiler will warn if a caller ignores the result. The goal is to catch futur…

Compiler annotation added to enforce checking of error-returning functionsNo specific vulnerability fixed in the diffNo functional code changes or call-site fixes included
909a89aaby Mike Tolkachev+215−15225 files
No security note in commit
Low 46 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

identity: add identity string validation

This commit adds a safety check to Blockstream Jade's 'sign identity' feature. Before the change, the device would accept any identity string a connected app sent. Now it rejects identities that contain non-printable or unusual characters.…

Input validation added to a signing/identity processNew length-bounded string helper reduces reliance on null-terminationRejection of non-printable characters in user-presented identity string
53752b98by Mike Tolkachev+22−02 files
No security note in commit
Informational 22 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

otp: show error on invalid issuer, share logging strings

This commit tightens error handling when decoding the 'issuer' field of an OTP (one-time password) setup URI. Previously, a malformed issuer string could fail to decode silently; now the device shows an error and cancels the operation inst…

Input validation added for OTP URI issuer fieldSilent failure on malformed URL-decoding replaced with explicit error returnDebug assertion added for label/issuer URL-decoding in UI display path
66c945f2by Mike Tolkachev+9−52 files
No security note in commit
Low 42 AI analysisMessage 28 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

psbt: fix path size

This commit fixes a small but meaningful bug in how Jade, a hardware wallet, reads key paths from Bitcoin PSBT data. The code was passing the byte size of a buffer when it should have passed the number of 32-bit entries. Depending on how t…

Buffer-size semantic mismatch in security-critical PSBT parsingUse of sizeof() on uint32_t array where element count is expectedCode path involved in 2of3 multisig recovery key identification
9e0c3747by Mike Tolkachev+2−21 file
No security note in commit
Moderate 57 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign: match sign_tx logic for output commitment checking

This commit fixes a logic gap in how Blockstream Jade checks cryptographic commitments for transaction outputs during signing. Previously, the code treated a missing commitment the same as an invalid one, which could cause the device to re…

Inconsistent commitment validation between signing code pathsPossible transaction signing failure or acceptance of unvalidated output commitmentsLogic alignment with existing sign_tx commitment handling
be05deacby Jon Griffiths+5−21 file
No security note in commit
Low 26 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

utils: fix params_additional_info return type

This commit changes the declared return type of a transaction-signing helper function from a transaction-type code (TxType_t) to a simple success/fail boolean (bool). The function body already appears to return true/false, so the change fi…

Return-type mismatch between function declaration/definition and headerFunction is in transaction-signing utility code (sign_utils.c/h)Function handles CBOR transaction parameters and writes output transaction metadata
3d6cdbcbby Jon Griffiths+2−22 files
No security note in commit
Moderate 61 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

url: improve bounds checking

This commit tightens bounds checks in URL encoding/decoding functions used in Blockstream Jade, a hardware wallet. The changes fix potential off-by-one/out-of-bounds memory reads and writes when handling percent-encoded characters. Because…

Bounds-check rewrite in URL decoder to prevent out-of-bounds reads before percent-decodingCast to unsigned char moved into isxdigit() to avoid undefined behavior with signed char inputsDestination bounds checks in URL encoder changed from pointer-subtraction form to remaining-space form, mitigating possible underflow/wrap
c045aeacby Mike Tolkachev+5−71 file
Vendor flagged security relevance
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritydisplay: share code to fetch the display bufferby Jon Griffiths · 829756be · Sep 8, 2025 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths

display: share code to fetch the display buffer

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritydisplay: optimize double-buffered icon drawingby Jon Griffiths · 07e5b674 · Sep 8, 2025 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · Jon Griffiths

display: optimize double-buffered icon drawing

co-authored-by: Larry Bank <bitbank@pobox.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-prioritydisplay: optimize grayscale image displayby Jon Griffiths · e9ff3035 · Sep 7, 2025 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · Jon Griffiths

display: optimize grayscale image display

suggested-by: Larry Bank <bitbank@pobox.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityconsistency: remove uneeded reference through pointerby Jon Griffiths · fc74c060 · Sep 7, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

consistency: remove uneeded reference through pointer

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityqr: use larger guides for seedqr/totp scanning on jade plusby Jon Griffiths · 71280e5b · Sep 4, 2025 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

qr: use larger guides for seedqr/totp scanning on jade plus

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidateRevert "camera: use VGA camera resolution for esp32s3"by Jon Griffiths · 346ceba4 · Sep 4, 2025 · 28 filesMessage 73 · AdequateInformational 15Details
Commit message · Jon Griffiths

Revert "camera: use VGA camera resolution for esp32s3"

QVGA appears to give faster and more accurate results when scanning than
VGA for Jade Plus.

Includes some minor cleanup since the surrounding code has changed
slightly.

This reverts commit 52df98693c8938f3322f8a780cd7451d3a6fa775.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
seed or entropy pathsigning or wallet path
AI analysis · Informational 15/100

This commit reverts a previous change that made the Jade Plus (ESP32-S3) camera use a higher VGA resolution. It returns all hardware variants to the lower QVGA resolution because QVGA was found to scan QR codes faster and more accurately on Jade Plus. It also removes the larger VGA test images and simplifies the output-message buffer size logic. There is no security fix or vulnerability here.

AI review queuedv2jadesign: allow giving the device serial port to sign withby Jon Griffiths · 882311d8 · Sep 4, 2025 · 1 fileMessage 50 · ThinInformational 19Details
Commit message · Jon Griffiths

v2jadesign: allow giving the device serial port to sign with

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit updates a release signing helper script so the operator can optionally specify which serial port a connected Jade hardware device uses. It is a usability/operational change, not a fix for a software vulnerability in the device or wallet itself. There is no indication it addresses a security incident.

AI review queuedjadepy: fix logging nitby Jon Griffiths · fac46b7d · Sep 4, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

jadepy: fix logging nit

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit fixes a trivial typo in a debug log message: a missing space between two words ('length ...and encoding' becomes 'length ... and encoding'). It has no effect on program logic, security, or behavior.

Lower-prioritybuild: check the firmware hash against the downloaded fileby Jon Griffiths · f42e0a0b · Sep 4, 2025 · 1 fileMessage 62 · AdequateTriage 0Details
Commit message · Jon Griffiths

build: check the firmware hash against the downloaded file

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-prioritybuild: print firmware hash in console before writing to the fileby Pablo Greco · 718f7a2f · Sep 4, 2025 · 1 fileMessage 62 · AdequateTriage 0Details
Commit message · Pablo Greco

build: print firmware hash in console before writing to the file

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-prioritybuild: check for unindexed firmware deltasby Jon Griffiths · 5ed5d8a6 · Sep 4, 2025 · 1 fileMessage 72 · AdequateTriage 0Details
Commit message · Jon Griffiths

build: check for unindexed firmware deltas

Produce a script to delete them if found (hopefully this will not occur
again once the tooling is further updated).

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Lower-prioritybuild: use rsync to sync firmware files for releasingby Jon Griffiths · bbf437a6 · Sep 4, 2025 · 1 fileMessage 97 · StrongTriage 0Details
Commit message · Jon Griffiths

build: use rsync to sync firmware files for releasing

Reduces the time taken to sync from several hours to under a minute.

Also improve the consistency checks to ensure that hashes are present
for later releases.

97/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Lower-priorityjade_ota.py: remove download error conditions and be verbose about defaultsby Jon Griffiths · 40200528 · Sep 4, 2025 · 1 fileMessage 85 · StrongTriage 0Details
Commit message · Jon Griffiths

jade_ota.py: remove download error conditions and be verbose about defaults

Passing uneeded arguments is not harmful, so don't fail unnecessarily.

If we assume the hardware type, be explicit we have done so, since
otherwise the resulting firmware will refuse to flash with a non-obvious
error.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Lower-priorityjade_ota.py: fetch and log device info before fetching fwby Jon Griffiths · 73f4274e · Sep 4, 2025 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Jon Griffiths

jade_ota.py: fetch and log device info before fetching fw

Lets not start downloading or start the OTA before we have shown the
user which device is going to be used.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityjade_ota.py: fetch the firmware to upload once the device is connectedby Jon Griffiths · dc9f8b76 · Sep 4, 2025 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Jon Griffiths

jade_ota.py: fetch the firmware to upload once the device is connected

We need to have the device so we can sensibly default the hardware
device from its info in an uncoming commit. Also make sure we only
fetch the device info once, since BLE is slow.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityjade_ota.py: be more helpful when --no-extended-replies is/is not neededby Jon Griffiths · 6e046a25 · Sep 4, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

jade_ota.py: be more helpful when --no-extended-replies is/is not needed

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityjade_ota.py: port the hw target defaulting logic from update_jade_fw.pyby Jon Griffiths · 9a67fae9 · Sep 4, 2025 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Jon Griffiths

jade_ota.py: port the hw target defaulting logic from update_jade_fw.py

Prevents defaulting to the wrong HW and failing with an 'invalid firmware'
error.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityjade_ota.py: move firmware fetching code into its own functionby Jon Griffiths · 61650e03 · Sep 4, 2025 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Jon Griffiths

jade_ota.py: move firmware fetching code into its own function

For review simplicity, no functional changes.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-prioritybuild: disable the gcov buildby Jon Griffiths · c12a9ce1 · Sep 4, 2025 · 1 fileMessage 72 · AdequateTriage 0Details
Commit message · Jon Griffiths

build: disable the gcov build

This isn't working, hasn't for a long time and in any case will likely
be replaced once local build support is merged.

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Lower-priorityui: update the Japan compliance number for Jadev2.0by Jon Griffiths · fab9cb3b · Sep 4, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

ui: update the Japan compliance number for Jadev2.0

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidatesign_psbt: update input amounts when additional_info is presentby Jon Griffiths · 8c93b592 · Sep 4, 2025 · 1 fileMessage 50 · ThinModerate 59Details
Commit message · Jon Griffiths

sign_psbt: update input amounts when additional_info is present

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 59/100

This commit fixes a bug in how Blockstream Jade signs Liquid Bitcoin transactions. When extra data ('additional_info') was provided for a transaction input, the hardware wallet was not updating its internal running totals of input amounts per asset. This could cause the device to miscalculate whether a transaction is balanced—potentially allowing a malicious or buggy host to trick the wallet into approving a transaction that silently moves more value than the user expects. The fix makes the wallet explicitly require and record the input's asset and amount in this code path.

Security candidatetests: remove existing test pin data before running the testby Jon Griffiths · d04bb0e4 · Sep 4, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Jon Griffiths

tests: remove existing test pin data before running the test

This makes e.g. debugging less painful.

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
access control
AI analysis · Informational 15/100

This change only affects the project's test script. It deletes leftover test PIN files before running tests so developers don't get confused by stale data from earlier runs. There is no security issue in the product itself.

Lower-prioritytests: add a singlesig swap pset testby Jon Griffiths · e79279b6 · Sep 4, 2025 · 1 fileMessage 55 · ThinTriage 0Details
Commit message · Jon Griffiths

tests: add a singlesig swap pset test

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Lower-prioritywire: differentiate between invalid cbor and malformed cbor errorsby Jon Griffiths · 89620da2 · Sep 4, 2025 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

wire: differentiate between invalid cbor and malformed cbor errors

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidatetests: add green multisig liquid pset test casesby Jon Griffiths · 0e2cfe79 · Sep 4, 2025 · 3 filesMessage 83 · StrongInformational 15Details
Commit message · Jon Griffiths

tests: add green multisig liquid pset test cases

The expected result PSBT is the PSBT signed using the default Green
software signer.

Note that we don't include the transaction hex. The previous commit
ensures we can extract it, but the Green transaction hex returned by gdk
includes dummy signatures/scriptsigs etc for fee estimation purposes.
These won't match the tx extracted from the signed PSBT.

All signed PSBTs have been confirmed to contain the valid user
signature.

83/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit only adds new test cases for signing Liquid multisig transactions on the Blockstream Jade hardware wallet. It introduces two JSON test fixtures and a one-line change to include them in the test suite. There is no change to production code, no bug fix, and no security-relevant behavior.