Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit fixes a bug where the touchscreen driver failed to clean up internal handles when shutting down. On newer ESP-IDF firmware, this cleanup failure caused the device to panic and freeze during boot and when using the camera or QR …
Device freeze/DoS-like symptom on affected hardwareMemory leak fixedNo input validation, authentication, or cryptographic weakness visible
This commit changes how Blockstream Jade handles the 'genesis blockhash' when signing Liquid transactions. Previously, the device only accepted the network's built-in genesis hash. Now it lets users provide a custom genesis hash for test n…
Adds input validation for caller-supplied genesis blockhashPrevents mainnet genesis hash from being used on Liquid test networksRestricts genesis_hash parameter to Liquid networks only
This commit adds compiler annotations (WARN_UNUSED_RESULT) to functions that return success/failure codes, so the compiler will warn if a caller ignores the result. It also fixes a few places where return values were being ignored, replaci…
Functions returning error/success codes annotated with WARN_UNUSED_RESULTCallers now check return values of rpc_get_bip32_path() and rpc_get_boolean()Use of default-value helpers (rpc_get_boolean_or) to ensure predictable behavior on missing fields
This commit simply renames an internal helper function from `rpc_get_uint64_t` to `rpc_get_uint64` and updates every place that calls it. There are no changes to what the function does, how it checks data, or how secure it is. It is a rout…
This commit is a simple rename of two internal helper functions from `rpc_get_boolean`/`rpc_get_boolean_or` to `rpc_get_bool`/`rpc_get_bool_or`, updating all call sites accordingly. There is no change to what the code does, no bug fix, and…
This commit is a straightforward code cleanup that replaces verbose 'read this optional value, or leave the default' patterns with shorter helper functions that do the same thing. There is no change in behavior and no security issue visibl…
This commit tightens how Blockstream Jade handles the 'precision' value in asset contracts for Liquid assets. Previously, a very large precision value could be accepted and later used to read past the end of an internal lookup table (POW_1…
Out-of-bounds read mitigation: bounds-checking of user-controlled precision before indexing fixed-size POW_10 arrayInteger truncation safety: explicit cast of validated precision to uint8_t after range checkCompile-time invariant enforcement: JADE_STATIC_ASSERT ties array size to ASSET_PRECISION_MAX
This commit is a large feature/refactor patch for Blockstream Jade's libjade (a desktop emulator of the Jade hardware wallet). It adds RPC endpoints that let a host application read the emulated device's screen, push fake button presses, r…
New RPC endpoints allow external read/write of emulated NVS storageNew RPC endpoints allow external screen capture and synthetic input injectionNew RPC endpoints allow external camera frame injection
This commit fixes a user-interface navigation quirk on the M5StickC Plus 2 hardware for Blockstream Jade. When entering a PIN, the up/down button directions were not inverted to match the rest of the device's menus, making number entry con…
This commit is a preventive build-hardening change. It adds compiler annotations (WARN_UNUSED_RESULT) to many functions that return success/failure codes, so the compiler will warn if a caller ignores the result. The goal is to catch futur…
Compiler annotation added to enforce checking of error-returning functionsNo specific vulnerability fixed in the diffNo functional code changes or call-site fixes included
This commit adds a safety check to Blockstream Jade's 'sign identity' feature. Before the change, the device would accept any identity string a connected app sent. Now it rejects identities that contain non-printable or unusual characters.…
Input validation added to a signing/identity processNew length-bounded string helper reduces reliance on null-terminationRejection of non-printable characters in user-presented identity string
This commit tightens error handling when decoding the 'issuer' field of an OTP (one-time password) setup URI. Previously, a malformed issuer string could fail to decode silently; now the device shows an error and cancels the operation inst…
Input validation added for OTP URI issuer fieldSilent failure on malformed URL-decoding replaced with explicit error returnDebug assertion added for label/issuer URL-decoding in UI display path
This commit fixes a small but meaningful bug in how Jade, a hardware wallet, reads key paths from Bitcoin PSBT data. The code was passing the byte size of a buffer when it should have passed the number of 32-bit entries. Depending on how t…
Buffer-size semantic mismatch in security-critical PSBT parsingUse of sizeof() on uint32_t array where element count is expectedCode path involved in 2of3 multisig recovery key identification
This commit fixes a logic gap in how Blockstream Jade checks cryptographic commitments for transaction outputs during signing. Previously, the code treated a missing commitment the same as an invalid one, which could cause the device to re…
Inconsistent commitment validation between signing code pathsPossible transaction signing failure or acceptance of unvalidated output commitmentsLogic alignment with existing sign_tx commitment handling
This commit changes the declared return type of a transaction-signing helper function from a transaction-type code (TxType_t) to a simple success/fail boolean (bool). The function body already appears to return true/false, so the change fi…
Return-type mismatch between function declaration/definition and headerFunction is in transaction-signing utility code (sign_utils.c/h)Function handles CBOR transaction parameters and writes output transaction metadata
This commit tightens bounds checks in URL encoding/decoding functions used in Blockstream Jade, a hardware wallet. The changes fix potential off-by-one/out-of-bounds memory reads and writes when handling percent-encoded characters. Because…
Bounds-check rewrite in URL decoder to prevent out-of-bounds reads before percent-decodingCast to unsigned char moved into isxdigit() to avoid undefined behavior with signed char inputsDestination bounds checks in URL encoder changed from pointer-subtraction form to remaining-space form, mitigating possible underflow/wrap
This commit fixes a bug in the Blockstream Jade hardware wallet's PSBT (Partially Signed Bitcoin Transaction) signing code. Previously, when the transaction's genesis block hash did not match the expected network, the code set an error mes…
Missing return in error path allows execution to continue after validation failureCross-network genesis hash mismatch not enforced as a hard failurePSBT signing logic accepts mismatched network parameters
This commit fixes a bug in the PIN-change flow on Blockstream Jade hardware wallets. Previously, if re-encrypting the wallet keys with a new PIN failed, or if the user abandoned the PIN change, the code did not jump to cleanup as intended.…
Missing error-path control flow in cryptographic key handlingPotential use of stale or partially initialized key material after PIN-change failureCleanup bypass in sensitive authentication code path
This commit fixes a bug in the Blockstream Jade hardware wallet's attestation signing process. Previously, if signing the attestation challenge failed, the device would send an error message but then continue running the rest of the functi…
Missing return after error path allows fall-through to success-path replyUninitialized output.ext_signature_len could leak stack data or cause undefined behaviorAttestation signing failure could result in sending an invalid attestation reply
This commit fixes a small but real bug in the device attestation setup code for Blockstream Jade, a hardware crypto wallet. When a one-time programmable security fuse failed to burn, the code used to exit immediately without releasing memo…
Missing cleanup on error path in security-critical initializationResource leak on failed efuse writePotential inconsistent attestation state after partial initialization
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Lower-prioritybuild: add 'tools/switch_to.sh' to switch between different configsby Daniel Newton · 84578147 · Dec 3, 2025 · 1 fileMessage 77 · AdequateTriage 0Details
Commit message · Daniel Newton
build: add 'tools/switch_to.sh' to switch between different configs
Preferred to adding more sdkconfig.default files.
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Lower-prioritylog: added CONFIG_LOG_CBOR (default off) to control logging via jade serial APIby Daniel Newton · 95653c19 · Dec 3, 2025 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Daniel Newton
log: added CONFIG_LOG_CBOR (default off) to control logging via jade serial API
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritydocs: add security caveat and @DarkNavyOrg thanks to changelogby Jon Griffiths · 619baa1b · Dec 3, 2025 · 1 fileMessage 67 · AdequateTriage 0Details
Commit message · Jon Griffiths
docs: add security caveat and @DarkNavyOrg thanks to changelog
67/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
documentation-only discount
Lower-prioritybuild: only check hashes that are presentby Jon Griffiths · 895bab82 · Dec 3, 2025 · 1 fileMessage 57 · ThinTriage 0Details
Commit message · Jon Griffiths
build: only check hashes that are present
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-prioritybuild: only generate deltas that are 1/2 the firmware size or lessby Jon Griffiths · 239b9c14 · Dec 3, 2025 · 3 filesMessage 62 · AdequateTriage 0Details
Commit message · Jon Griffiths
build: only generate deltas that are 1/2 the firmware size or less
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-prioritybuild: increment the firmware secure versionby Jon Griffiths · 3457a52c · Nov 18, 2025 · 6 filesMessage 57 · ThinTriage 0Details
Commit message · Jon Griffiths
build: increment the firmware secure version
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · fb264239 · Nov 18, 2025 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Jon Griffiths
Update CHANGELOG.md
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Lower-priorityusb: refactor usb handlingby Jon Griffiths · c0606dc3 · Nov 6, 2025 · 4 filesMessage 58 · ThinTriage 0Details
Commit message · Jon Griffiths
usb: refactor usb handling
- Simplify the USB caller interface down to start() and stop(). - Simplify the internal state machine to a single loop - Remove multiple synchronization primatives in favour of a single mutex - Prevent freezing when JTAG and logging are both enabled - Remove UI-based logging support - Load the next data block while the current one is processing - Time-out if ota_data messages are not forthcoming - Reduce stack usage
Co-authored-by: Daniel Newton <dnewton@blockstream.com>
Lower-priorityci: include sdkconfig.defaults in firmware build artifactsby Jon Griffiths · 0d883e1e · Nov 6, 2025 · 1 fileMessage 62 · AdequateTriage 0Details
Commit message · Jon Griffiths
ci: include sdkconfig.defaults in firmware build artifacts
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-prioritychange name of usb_connected() to usb_is_powered()by Daniel Newton · 61690c66 · Nov 6, 2025 · 18 filesMessage 50 · ThinTriage 0Details
Commit message · Daniel Newton
change name of usb_connected() to usb_is_powered()
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityota: share error handling codeby Jon Griffiths · 3f207eeb · Oct 30, 2025 · 4 filesMessage 60 · AdequateTriage 0Details
Commit message · Jon Griffiths
ota: share error handling code
Attempt to be more careful about replying without a current message or replying to a given message twice.
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityota: make user validation set the ota and confirmation statusby Jon Griffiths · 9314a4f9 · Oct 30, 2025 · 4 filesMessage 73 · AdequateTriage 0Details
Commit message · Jon Griffiths
ota: make user validation set the ota and confirmation status
This makes confirmation status easier to reason about as it is only set in one place after ota_init().
Following this, it is clear that if the decompressed data callback is initially called with less than the full custom header, then user validaton will never be called. Document the code that catches this case and how it can happen.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityota: ensure error replies are sent if firmware sizes mismatchby Jon Griffiths · 495f6278 · Oct 30, 2025 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Jon Griffiths
ota: ensure error replies are sent if firmware sizes mismatch
If ota_complete is not seen, return directly. This code path does not set an error into the context, and so never enters the cleanup code.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityota: initial refactor of ota processingby Jon Griffiths · b1437349 · Oct 30, 2025 · 4 filesMessage 68 · AdequateTriage 0Details
Commit message · Jon Griffiths
ota: initial refactor of ota processing
Push all state into the ota context struct, allocate it from the heap and free it consistently on process exit. Use the context to simplify error handling rather than forcing callers to maintain their own external context variables.
Share the initial message processing and ota setup code between the full and delta ota tasks since its almost completely identical.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityota: make finalization set the ota statusby Jon Griffiths · 8a710d86 · Oct 30, 2025 · 4 filesMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths
ota: make finalization set the ota status
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityota: perform the happy path processing in ota_finalize()by Jon Griffiths · 04198416 · Oct 30, 2025 · 4 filesMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths
ota: perform the happy path processing in ota_finalize()
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityota: add missing jumps to cleanup codeby Jon Griffiths · 3700ef34 · Oct 30, 2025 · 2 filesMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths
ota: add missing jumps to cleanup code
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityusb: use usbstorage_register_callback to unregisterby Jon Griffiths · 057dd310 · Oct 28, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths
usb: use usbstorage_register_callback to unregister
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityota: remove write-through pointer members from ota context structby Jon Griffiths · 6e2c00ec · Oct 28, 2025 · 4 filesMessage 65 · AdequateTriage 0Details
Commit message · Jon Griffiths
ota: remove write-through pointer members from ota context struct
We are already writing through the context pointer, the extra indirection uses more stack with no benefit.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityusb: restore the previous activity before running a usbstorage actionby Jon Griffiths · 7483976f · Oct 28, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths
usb: restore the previous activity before running a usbstorage action
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityusb: avoid memory allocations for ota chunk databy Jon Griffiths · f0ebdd09 · Oct 23, 2025 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths
usb: avoid memory allocations for ota chunk data
Prevents fragmentation.
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityusb: avoid stdio overhead and buffering when reading ota databy Jon Griffiths · acac6fa5 · Oct 23, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths
usb: avoid stdio overhead and buffering when reading ota data
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityusb: refactor the ota data loopby Jon Griffiths · e260f656 · Oct 23, 2025 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Jon Griffiths
usb: refactor the ota data loop
- Allow parallelism by waiting on the previous data packet not the current one - Handle scenarios where the ota process stops responding to our messages - Clean up error handling to simplify the loop logic.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context